Skip to content

chore(samples): run the Android build on Gradle 9.1 and Crashlytics 3.0 - #3067

Merged
xsahil03x merged 1 commit into
masterfrom
chore/samples-gradle-9
Oct 16, 2026
Merged

xsahil03x merged 1 commit into
masterfrom
chore/samples-gradle-9

Conversation

@xsahil03x

@xsahil03x xsahil03x commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

The sample app's Android build fails on current Android Studio: Gradle 8.14 doesn't run on its bundled Java 25. This moves the Gradle wrapper to 9.1.0, the first release that supports Java 25, and the Crashlytics Gradle plugin to 3.0.0, because 2.8.1 uses groovy.util.XmlSlurper, which Gradle 9 removed (release builds failed at uploadCrashlyticsMappingFileRelease). Both are the minimum versions that work.

Verified with release APK builds on Flutter 3.44.0 and 3.47.5; 2.8.1 on Gradle 9.1.0 still fails, so the plugin bump is needed. Split out of #3023.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the tooling used to build the Android app. This change affects the app’s build setup; no end-user-facing features or behavior changes are included.

Gradle 8.14 doesn't run on Java 25, which current Android Studio bundles;
9.1.0 is the first release that does. Crashlytics' Gradle plugin 2.8 uses
groovy.util.XmlSlurper, which Gradle 9 removed, so release builds failed
while uploading the mapping file; 3.0.0 is the first release that works.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 571382f8-3185-4aae-a6d5-93b4180dd98d
📥 Commits

Reviewing files that changed from the base of the PR and between 8d76439 and 05331a2.

📒 Files selected for processing: 2
  • sample_app/android/gradle/wrapper/gradle-wrapper.properties
  • sample_app/android/settings.gradle

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The Android sample app updates its Gradle wrapper to Gradle 9.1.0 and its Firebase Crashlytics Gradle plugin to version 3.0.0.

Changes: Android build versions

Layer / File(s) Summary
Update Android build versions
sample_app/android/gradle/wrapper/gradle-wrapper.properties, sample_app/android/settings.gradle
The wrapper distribution changes from Gradle 8.14.3 to 9.1.0. The Firebase Crashlytics Gradle plugin changes from 2.8.1 to 3.0.0.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 05331

The Android build versions are updated, but available compatibility evidence establishes no concrete release-build failure or resulting user impact; no actionable merge blocker remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main changes: updating the Android build to Gradle 9.1 and Crashlytics 3.0.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.56%. Comparing base (8d76439) to head (05331a2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3067   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files         452      452           
  Lines       29451    29451           
=======================================
  Hits        23139    23139           
  Misses       6312     6312           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xsahil03x
xsahil03x merged commit 6c8cee1 into master Oct 16, 2026
30 checks passed
@xsahil03x
xsahil03x deleted the chore/samples-gradle-9 branch October 16, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants