fix(ui): stop the poll option votes and comments dialogs listing other votes (v9) by VelikovPetar · Pull Request #3060 · GetStream/stream-chat-flutter

VelikovPetar · 2026-10-14T07:40:02Z

Submit a pull request

Linear: FLU-975
Github Issue: #

CLA

I have signed the Stream CLA (required).
The code changes follow best practices
Code changes are tested (add some information if not applicable)

Description of the pull request

Port of #3059 to v9. Stacked on #3058 (the v9 port of #3057) — review that first; this PR's base is its branch.

StreamPollOptionVotesDialog and StreamPollCommentsDialog scoped their StreamPollVoteListController only with a Filter (option_id / is_answer), which applies to the REST query alone. Live events went through the default StreamPollVoteEventHandler, which adds every cast vote and upserts every changed vote by id. So:

a vote cast for another option, or an answer, appeared in an option's voters dialog;
a vote changed from this option to another stayed listed, updated in place to the other option;
votes for poll options appeared as comments.

The SDK can't evaluate an arbitrary Filter locally, so stream_chat_flutter_core gets two constructors that tell the controller what the list covers:

StreamPollVoteListController.forOption(channel:, pollId:, optionId:)
StreamPollVoteListController.forAnswers(channel:, pollId:)

Each queries only those votes and makes the default handler ignore cast votes outside the list and remove a vote changed out of it. Both dialogs use them.

Additive only: the default constructor and .fromValue behave as before, and StreamPollVoteEventHandler's signatures are unchanged.

This matches iOS, whose PollVoteListQuery(pollId:optionId:) only links a non-answer vote when query.optionId == vote.optionId.

Same change as #3059; only formatting (80 columns) and the sheet → dialog naming differ.

Testing

stream_poll_vote_list_controller_test.dart (fix(core): ignore other polls' votes in StreamPollVoteListController (v9) #3058's file): option and answers scopes — the queried filter, cast votes inside/outside the scope, votes changed into/out of an option, answers vs option votes — plus whole-poll removal and change. The out-of-scope tests fail without the fix.
New stream_poll_option_votes_dialog_test.dart and stream_poll_comments_dialog_test.dart: an other-option vote isn't listed, a vote changed to another option stops being listed, an option vote isn't shown as a comment. They fail on the old dialogs.
Analyze clean; stream_chat_flutter_core suite passes.

Screenshots / Videos

Before	After
—	—

🤖 Generated with Claude Code

…r votes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

coderabbitai · 2026-10-14T07:40:12Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 45b635c8-6deb-4239-8536-923611a53e00

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-10-14T08:00:25Z

Codecov Report

❌ Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.55%. Comparing base (df3c856) to head (04862ec).

Files with missing lines	Patch %	Lines
...core/lib/src/stream_poll_vote_list_controller.dart	96.87%	1 Missing ⚠️

Additional details and impacted files

@@                              Coverage Diff                              @@
##           fix/flu-974_poll_vote_list_other_polls_v9    #3060      +/-   ##
=============================================================================
+ Coverage                                      68.87%   69.55%   +0.68%     
=============================================================================
  Files                                            435      435              
  Lines                                          27711    27738      +27     
=============================================================================
+ Hits                                           19085    19294     +209     
+ Misses                                          8626     8444     -182

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

xsahil03x

Faithful port of #3059: the controller is identical apart from v9's own base (package: import, no disposed guard), the dialogs get the same one-line swaps, and v9's answer resolver keeps the payload the same way. Correct for the same reasons as #3059, and CI is green.

The inline comments mirror #3059: rename option / answers → forOption / forAnswers and fix the "live votes" wording. The handler-doc suggestions are rewrapped for v9's 80-column limit. None block.

On the description: same as #3059, the "Notes:" section reads better as comments on the lines it justifies.

xsahil03x · 2026-10-14T13:54:08Z

+  /// Creates a Stream poll vote list controller that lists only the votes for
+  /// the poll option with `optionId`.
+  ///
+  /// Live votes for other options and answers are ignored, and a vote changed
+  /// to another option is removed. Setting [filter] later changes only the
+  /// query; live votes stay limited to this option.
+  StreamPollVoteListController.option({


Same as #3059: StreamPollVoteListController.option(...) reads as if the controller were an option. Suggest forOption (paired with forAnswers below), which reads as "the vote list for this option". Singular, since it takes one optionId.

Also: "live votes" isn't defined anywhere; saying when the votes arrive is clearer.

Suggested change

/// Creates a Stream poll vote list controller that lists only the votes for

/// the poll option with `optionId`.

///

/// Live votes for other options and answers are ignored, and a vote changed

/// to another option is removed. Setting [filter] later changes only the

/// query; live votes stay limited to this option.

StreamPollVoteListController.option({

/// Creates a Stream poll vote list controller that lists only the votes for

/// the poll option with `optionId`.

///

/// Votes for other options and answers cast while the list is loaded are

/// ignored, and a vote changed to another option is removed. Setting [filter]

/// later changes only the query; incoming votes stay limited to this option.

StreamPollVoteListController.forOption({

Renamed to forOption and applied the wording in 04862ec.

xsahil03x · 2026-10-14T13:54:08Z

+  /// Creates a Stream poll vote list controller that lists only the answers of
+  /// the poll.
+  ///
+  /// Live votes for poll options are ignored. Setting [filter] later changes
+  /// only the query; live votes stay limited to answers.
+  StreamPollVoteListController.answers({


Pair with forOption above, and the same "live votes" wording fix.

Suggested change

/// Creates a Stream poll vote list controller that lists only the answers of

/// the poll.

///

/// Live votes for poll options are ignored. Setting [filter] later changes

/// only the query; live votes stay limited to answers.

StreamPollVoteListController.answers({

/// Creates a Stream poll vote list controller that lists only the answers of

/// the poll.

///

/// Option votes cast while the list is loaded are ignored. Setting [filter]

/// later changes only the query; incoming votes stay limited to answers.

StreamPollVoteListController.forAnswers({

Renamed to forAnswers and applied the wording in 04862ec.

xsahil03x · 2026-10-14T13:54:08Z

+  /// [StreamPollVoteListController.option] or
+  /// [StreamPollVoteListController.answers] ignores votes for other options or
+  /// votes that aren't answers, respectively.


Rename to match forOption / forAnswers, rewrapped to stay within 80 columns.

Suggested change

/// [StreamPollVoteListController.option] or

/// [StreamPollVoteListController.answers] ignores votes for other options or

/// votes that aren't answers, respectively.

/// [StreamPollVoteListController.forOption] or

/// [StreamPollVoteListController.forAnswers] ignores votes for other options

/// or votes that aren't answers, respectively.

Done in 04862ec.

xsahil03x · 2026-10-14T13:54:08Z

+  /// [StreamPollVoteListController.option] or
+  /// [StreamPollVoteListController.answers] instead removes a vote that is no
+  /// longer for that option or isn't an answer, respectively.


Rename to match forOption / forAnswers, rewrapped to stay within 80 columns.

Suggested change

/// [StreamPollVoteListController.option] or

/// [StreamPollVoteListController.answers] instead removes a vote that is no

/// longer for that option or isn't an answer, respectively.

/// [StreamPollVoteListController.forOption] or

/// [StreamPollVoteListController.forAnswers] instead removes a vote that is

/// no longer for that option or isn't an answer, respectively.

Done in 04862ec.

xsahil03x · 2026-10-14T13:54:09Z


  void _initializeController() {
-    _controller = StreamPollVoteListController(
+    _controller = StreamPollVoteListController.answers(


Rename to match forOption / forAnswers.

Suggested change

_controller = StreamPollVoteListController.answers(

_controller = StreamPollVoteListController.forAnswers(

Done in 04862ec.

xsahil03x · 2026-10-14T13:54:09Z

+  group('when the list is scoped to an option', () {
+    test('queries only the votes for the scoped option', () async {
+      final filter = await _queriedFilter(
+        (channel) => StreamPollVoteListController.option(


Rename to match forOption / forAnswers.

Suggested change

(channel) => StreamPollVoteListController.option(

(channel) => StreamPollVoteListController.forOption(

Done in 04862ec.

xsahil03x · 2026-10-14T13:54:09Z

+  group('when the list is scoped to answers', () {
+    test('queries only the answers', () async {
+      final filter = await _queriedFilter(
+        (channel) => StreamPollVoteListController.answers(


Rename to match forOption / forAnswers.

Suggested change

(channel) => StreamPollVoteListController.answers(

(channel) => StreamPollVoteListController.forAnswers(

Done in 04862ec.

xsahil03x · 2026-10-14T13:54:09Z

+}) {
+  return _loadedController(
+    votes: votes,
+    create: (channel) => StreamPollVoteListController.option(


Rename to match forOption / forAnswers.

Suggested change

create: (channel) => StreamPollVoteListController.option(

create: (channel) => StreamPollVoteListController.forOption(

Done in 04862ec.

xsahil03x · 2026-10-14T13:54:09Z

+      StreamController<Event> events
+    })> _loadedAnswersController() {
+  return _loadedController(
+    create: (channel) => StreamPollVoteListController.answers(


Rename to match forOption / forAnswers.

Suggested change

create: (channel) => StreamPollVoteListController.answers(

create: (channel) => StreamPollVoteListController.forAnswers(

Done in 04862ec.

xsahil03x · 2026-10-14T13:54:09Z


+✅ Added
+
+- Added `StreamPollVoteListController.option` and `StreamPollVoteListController.answers`, which list only a poll's votes for one option or only its answers.


Rename to match forOption / forAnswers.

Suggested change

- Added `StreamPollVoteListController.option` and `StreamPollVoteListController.answers`, which list only a poll's votes for one option or only its answers.

- Added `StreamPollVoteListController.forOption` and `StreamPollVoteListController.forAnswers`, which list only a poll's votes for one option or only its answers.

Done in 04862ec.

…ption and forAnswers Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

VelikovPetar · 2026-10-14T14:10:52Z

Thanks! Also trimmed the "Notes:" section in the description down to the compatibility note and the iOS comparison.

xsahil03x

Thanks, all applied in 04862ec, including the 80-column rewraps. LGTM.

fix(ui): stop the poll option votes and comments dialogs listing othe…

1940039

…r votes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

VelikovPetar marked this pull request as ready for review October 14, 2026 07:49

VelikovPetar added this pull request to stack #3062 October 14, 2026 07:50

VelikovPetar requested a review from a team October 14, 2026 07:50

xsahil03x reviewed Oct 14, 2026

View reviewed changes

xsahil03x mentioned this pull request Oct 14, 2026

fix(core): ignore other polls' votes in StreamPollVoteListController (v9) #3058

Merged

3 tasks done

refactor(core): rename the scoped poll vote list constructors to forO…

04862ec

…ption and forAnswers Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

xsahil03x approved these changes Oct 14, 2026

View reviewed changes

VelikovPetar merged commit 88231c1 into v9 Oct 15, 2026
20 checks passed

VelikovPetar deleted the fix/flu-975_poll_vote_list_scope_v9 branch October 15, 2026 11:33

	_controller = StreamPollVoteListController.answers(
	_controller = StreamPollVoteListController.forAnswers(

	(channel) => StreamPollVoteListController.option(
	(channel) => StreamPollVoteListController.forOption(

	create: (channel) => StreamPollVoteListController.option(
	create: (channel) => StreamPollVoteListController.forOption(


		✅ Added

		- Added `StreamPollVoteListController.option` and `StreamPollVoteListController.answers`, which list only a poll's votes for one option or only its answers.

	- Added `StreamPollVoteListController.option` and `StreamPollVoteListController.answers`, which list only a poll's votes for one option or only its answers.
	- Added `StreamPollVoteListController.forOption` and `StreamPollVoteListController.forAnswers`, which list only a poll's votes for one option or only its answers.

Conversation

VelikovPetar commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Submit a pull request

CLA

Description of the pull request

Testing

Screenshots / Videos

Uh oh!

coderabbitai Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

codecov Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

xsahil03x left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VelikovPetar commented Oct 14, 2026

Uh oh!

xsahil03x left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

VelikovPetar commented Oct 14, 2026 •

edited

Loading

coderabbitai Bot commented Oct 14, 2026 •

edited

Loading

codecov Bot commented Oct 14, 2026 •

edited

Loading