Skip to content

Allow closed version ranges in lint_swift_package - #14

Merged
testableapple merged 1 commit into
mainfrom
lint/allow-closed-version-ranges
Sep 18, 2026
Merged

testableapple merged 1 commit into
mainfrom
lint/allow-closed-version-ranges

Conversation

@ipavlidakis

Copy link
Copy Markdown
Contributor

🔗 Issue Links

Unblocks stream-video-swift release start after https://github.com/GetStream/stream-video-swift/actions/runs/35363258210/job/105659444936 (Package.swift uses "1.38.0"..."1.39.0" for swift-protobuf).

🎯 Goal

lint_swift_package already accepts from: / .upToNextMajor, but rejected tighter closed and half-open ranges. That blocked SDK releases that pin a bounded version window on purpose.

📝 Summary

  • Treat from:, exact:, .upToNextMajor, .upToNextMinor, "x"..."y", and "x"..<"y" as valid version requirements
  • Keep failing on branch, revision, local path, non-https URLs, and duplicates
  • Update specs to cover closed/half-open ranges instead of treating them as errors

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • New code is covered by unit tests

Test plan

  • bundle exec rake spec (lint_swift_package examples pass)
  • bundle exec rubocop on the changed files
  • After merge, cut a plugin patch (0.4.10) and bump fastlane/Pluginfile in stream-video-swift, then re-run the release

Made with Cursor

@ipavlidakis ipavlidakis self-assigned this Sep 18, 2026
@ipavlidakis ipavlidakis added the enhancement New feature or request label Sep 18, 2026
@testableapple
testableapple merged commit a4d8bb0 into main Sep 18, 2026
4 checks passed
@testableapple
testableapple deleted the lint/allow-closed-version-ranges branch September 18, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants