Repository navigation
fix: validate DiscreteAllocation prices and reject empty weights on allocate - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate prices for weighted tickers in DiscreteAllocation: missing tickers, zero, negative, or infinite prices now raise ValueError instead of producing bad allocations. Prices of tickers without weights are ignored. An empty weights dict is still accepted at construction (for utility methods) but greedy_portfolio and lp_portfolio raise ValueError.
Adds regression tests for missing prices, bad prices, unweighted-asset prices, and empty weights. Local run on this branch: 330 passed, 4 skipped. Own fork only, no upstream PR.