Repository navigation
fix: restore HRP optimization with current SciPy - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HRPOpt.optimize reads scipy.cluster.hierarchy._LINKAGE_METHODS, a private registry missing in SciPy 1.18.1. This raises AttributeError for every method, including the default, and causes five existing HRP tests plus the full CI matrix/coverage to fail independently of the discrete-allocation change in #1.
Delegate method validation to the public scipy.cluster.hierarchy.linkage API. Existing invalid-method inputs still raise ValueError. Add coverage for all seven methods documented by SciPy: https://docs.scipy.org/doc/scipy/reference/generated/scipy.cluster.hierarchy.linkage.html
Validation: reproduced five failures on the unmodified main HRP code with SciPy 1.18.1. All 13 HRP tests, including the seven documented-method cases, pass after this change.