Skip to content

fix(setup): update cursor post-install test after #522#524

Merged
Alan-TheGentleman merged 1 commit into
mainfrom
fix/523-cursor-postinstall-test
Jun 20, 2026
Merged

fix(setup): update cursor post-install test after #522#524
Alan-TheGentleman merged 1 commit into
mainfrom
fix/523-cursor-postinstall-test

Conversation

@Alan-TheGentleman

@Alan-TheGentleman Alan-TheGentleman commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

🔗 Linked Issue

Closes #523

🏷️ PR Type

  • type:bug

📝 Summary

TestPrintPostInstall/cursor (cmd/engram/main_test.go) still asserted the removed engram.mdc string after #522 switched Cursor to an informational engram-memory-protocol.md + manual User Rule step. Updates the expectation to the current output, fixing the failing CI on main.

🧪 Test Plan

  • go test ./cmd/engram/... and go build ./... pass

✅ Contributor Checklist

  • Linked an approved issue
  • One type:* label
  • Conventional commit, no Co-Authored-By

Summary by CodeRabbit

  • Tests
    • Updated validation tests for post-install configuration output to match current system behavior.

TestPrintPostInstall/cursor still asserted the removed 'engram.mdc' string after #522 switched Cursor to an informational engram-memory-protocol.md + manual User Rule step. Update the expectation to the current output. Closes #523.
Copilot AI review requested due to automatic review settings June 20, 2026 10:31
@Alan-TheGentleman Alan-TheGentleman added the type:bug Bug fix label Jun 20, 2026
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 34be5e4c-3d17-4009-854c-fd6272b8a8fc

📥 Commits

Reviewing files that changed from the base of the PR and between 9ee6b7f and 32c2410.

📒 Files selected for processing (1)
  • cmd/engram/main_test.go

📝 Walkthrough

Walkthrough

The TestPrintPostInstall "cursor" subtest in cmd/engram/main_test.go is updated to reflect the new Cursor post-install output: the expected string engram.mdc is replaced with engram-memory-protocol.md and User Rules, matching the output introduced in a prior change.

Changes

Cursor Post-Install Test Expectation

Layer / File(s) Summary
Update cursor expected stdout strings
cmd/engram/main_test.go
Replaces the stale engram.mdc assertion with engram-memory-protocol.md and User Rules in the TestPrintPostInstall cursor subtest to match current post-install output.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly and specifically references fixing a test after PR #522, which directly aligns with the changeset that updates TestPrintPostInstall expectations.
Linked Issues check ✅ Passed The PR successfully addresses the requirement from issue #523 by updating test expectations to match the new Cursor post-install behavior with engram-memory-protocol.md and User Rules instead of engram.mdc.
Out of Scope Changes check ✅ Passed All changes are narrowly scoped to fixing the failing TestPrintPostInstall/cursor test in cmd/engram/main_test.go as required by the linked issue, with no extraneous modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/523-cursor-postinstall-test

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the cmd/engram setup post-install output test for Cursor to match the behavior introduced in #522 (Cursor now writes an informational engram-memory-protocol.md file and instructs a manual “User Rules” paste step, rather than referencing the removed engram.mdc).

Changes:

  • Adjusted TestPrintPostInstall/cursor expectations to assert the new Cursor post-install guidance (engram-memory-protocol.md + “User Rules”).
  • Removes the stale assertion for engram.mdc, fixing the failing go test ./cmd/engram/... on main.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Alan-TheGentleman Alan-TheGentleman merged commit 44faeee into main Jun 20, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(setup): update TestPrintPostInstall cursor expectation after #522

2 participants