fix(setup): update cursor post-install test after #522#524
Conversation
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesCursor Post-Install Test Expectation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Updates the cmd/engram setup post-install output test for Cursor to match the behavior introduced in #522 (Cursor now writes an informational engram-memory-protocol.md file and instructs a manual “User Rules” paste step, rather than referencing the removed engram.mdc).
Changes:
- Adjusted
TestPrintPostInstall/cursorexpectations to assert the new Cursor post-install guidance (engram-memory-protocol.md+ “User Rules”). - Removes the stale assertion for
engram.mdc, fixing the failinggo test ./cmd/engram/...on main.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🔗 Linked Issue
Closes #523
🏷️ PR Type
type:bug📝 Summary
TestPrintPostInstall/cursor(cmd/engram/main_test.go) still asserted the removedengram.mdcstring after #522 switched Cursor to an informationalengram-memory-protocol.md+ manual User Rule step. Updates the expectation to the current output, fixing the failing CI on main.🧪 Test Plan
go test ./cmd/engram/...andgo build ./...pass✅ Contributor Checklist
Summary by CodeRabbit