feat(mcp): support project override in mem_session_summary#504
feat(mcp): support project override in mem_session_summary#504DanielQuero wants to merge 4 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changesmem_session_summary explicit project resolution
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
DanielQuero
force-pushed
the
feat/mcp-session-summary-project-override
branch
from
da84019 to
f0bae3e
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
internal/mcp/mcp.go (1)
1886-1888:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAmbiguous-project hint is now stale for
mem_session_summaryretries.Line 1887 now routes
mem_session_summarythroughwriteProjectErrorResult, but the sharedambiguous_projecthint still tells clients to retry onlymem_save/mem_save_prompt. This can misdirect automated retries away from the original tool.Proposed fix
--- a/internal/mcp/mcp.go +++ b/internal/mcp/mcp.go @@ case "ambiguous_project": - envelope["hint"] = "Ask the user to choose one of available_projects, then retry mem_save or mem_save_prompt with project and project_choice_reason=user_selected_after_ambiguous_project; alternatively cd into the target repo or add repo .engram/config.json." + envelope["hint"] = "Ask the user to choose one of available_projects, then retry the same write tool (mem_save, mem_save_prompt, or mem_session_summary) with project and project_choice_reason=user_selected_after_ambiguous_project; alternatively cd into the target repo or add repo .engram/config.json."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@internal/mcp/mcp.go` around lines 1886 - 1888, The ambiguous_project hint currently only instructs clients to retry mem_save and mem_save_prompt, but since mem_session_summary is now being routed through writeProjectErrorResult on error, it can also trigger ambiguous project errors. Find where the ambiguous_project hint is defined and update it to include mem_session_summary as an additional tool that clients should retry when encountering this hint, ensuring automated retries are not misdirected away from the original tool.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@internal/mcp/mcp.go`:
- Around line 1886-1888: The ambiguous_project hint currently only instructs
clients to retry mem_save and mem_save_prompt, but since mem_session_summary is
now being routed through writeProjectErrorResult on error, it can also trigger
ambiguous project errors. Find where the ambiguous_project hint is defined and
update it to include mem_session_summary as an additional tool that clients
should retry when encountering this hint, ensuring automated retries are not
misdirected away from the original tool.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 3b4b9404-8c31-469b-8ee2-e95812c9a9b4
📒 Files selected for processing (2)
internal/mcp/activity.gointernal/mcp/mcp.go
DanielQuero
force-pushed
the
feat/mcp-session-summary-project-override
branch
from
f0bae3e to
066b11f
Compare
1 participant
🔗 Linked Issue
Closes 460
🏷️ PR Type
type:bug— Bug fixtype:feature— New featuretype:docs— Documentation onlytype:refactor— Code refactoring (no behavior change)type:chore— Maintenance, dependencies, toolingtype:breaking-change— Breaking change📝 Summary
project,project_choice_reason, andrecovery_tokenoptional parameters to themem_session_summaryMCP tool schema.handleSessionSummaryto use the robustresolveSaveWriteProjectWithProcessOverridehelper instead of relying solely on the process CWD.session_idor saved under an explicit project override, resolving compatibility issues with global MCP runs in Antigravity 2.0.📂 Changes
path/to/filemem_session_summaryschema and updated its handler to resolve projects using the full precedence chain.🧪 Test Plan
go test ./...go test -tags e2e ./internal/server/...Verified multi-project isolation in a live Antigravity IDE environment:
🤖 Automated Checks
These run automatically and all must pass before merge:
Closes #N/Fixes #N/Resolves #Nstatus:approvedlabeltype:*labelgo test ./...passesgo test -tags e2e ./internal/server/...passes✅ Contributor Checklist
Closes #N)type:*label to this PRgo test ./...go test -tags e2e ./internal/server/...Co-Authored-Bytrailers in commits💬 Notes for Reviewers
Summary by CodeRabbit
Summary by CodeRabbit
New Features
mem_session_summaryto allow explicit project targeting, including project-choice details and an ambiguous-project recovery token.Documentation
mem_session_summarytool docs to reflect the revised project-resolution precedence and supported override fields.Tests
projector resolving viasession_id.Bug Fixes