Repository navigation
feat: api to serve hotel signal data - #45
Merged
Merged
Conversation
7 tasks
bhuvanh66
changed the title
bhuvanh66
force-pushed
the
38-api-to-serve-hotel-signal-data
branch
2 times, most recently
from
October 12, 2026 20:15
0129a44 to
247a384
Compare
11 of 15 tasks
Add RequestSchema, ResponseSchema and ExternalPayload base classes and document the standard in agents/schemas.md. Convert the widget and hotel schemas from Create/Read to Request/Response without inheritance.
Hotels and room types (list, get, create), nightly performance by date range, and read-only weather, events and flight arrivals. List endpoints paginate; unknown ids return 404. The recommendation endpoint returns a placeholder in the final response shape. Schemas follow the Request/Response standard and repositories never commit. Co-authored-by: Vichu Selvaraju <vichuselvaraju@gmail.com>
selvarajuv
force-pushed
the
38-api-to-serve-hotel-signal-data
branch
from
October 13, 2026 18:08
247a384 to
7d0f1fd
Compare
selvarajuv
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #38
Type of change
Add routes for hotel and external data (routes, services, repository, tests). Still need to test routes with real external data and hotel data. All list endpoints have pagination, unknown IDs return 404s.
feat— new featurefix— bug fixdocs— documentation onlyrefactor— code change that neither fixes a bug nor adds a featureperf— performance improvementtest— adding or updating testschore/build/ci— tooling, deps, or pipeline changesChanges
Database migrations
just migrate-create "...")just migrate) and rolls back (just migrate-down)Checklist
just lint) and code is formatted (just format)just hooksinstalled).env.examplewhere relevantjust dev) and verified the API athttp://localhost:8000/docsHow to test
Notes for reviewers