Repository navigation
fix(bump-v1): annotate the release tag before moving v1 - #21
Merged
Merged
Conversation
With v1 and the release tag both lightweight on one commit, dunamai picks "v1" and copier reads the template version as 1. Port the annotate step from python-project-template 1.8.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports two changes from python-project-template that this template is missing. Both are already causing problems in the consumers.
Annotate the release tag (python-project-template 1.8.1)
v1andv1.1.0are both lightweight tags onece6092. Copier reads a template's version through dunamai. With two lightweight tags on one commit, dunamai picksv1:So the weekly template update in llm-prices and logfile-upload rewrote
_commit: v1.1.0and_commit: v1.0.0to_commit: v1. That rewrite is the whole diff on theirchore/template-updatebranches. In the Python template the same setup madecopier updatefail with "Downgrades are not supported".bump-v1.ymlnow annotates the release tag after its refusal checks and before it movesv1. The step is the Python template's, minus that repo's self-release path.Name the Actions setting that template-update needs
The update workflow opens its PR with the default
GITHUB_TOKEN, so it needs Allow GitHub Actions to create and approve pull requests. Neither consumer has it turned on. logfile-upload's first run (35599735536) pushed the branch and then failed withGitHub Actions is not permitted to create or approve pull requests. The README update section and the post-copy message now say so (the message only whenuse_template_updateis on).After merge
Cut v1.1.1 from the GitHub UI. The new step annotates
v1.1.1, andv1moves offece6092. No hand-annotation of v1.1.0 is needed, becausev1won't share its commit any more.Every later run in both consumers also fails at the push with
stale info. That bug is intemplate-update.ymlitself and has its own PR.Testing
zizmor --offline --persona=auditorare clean onbump-v1.yml.use_template_updateon and off. The message shows the new paragraph only when it is on, and the trailing whitespace is unchanged from main.🤖 Generated with Claude Code