Skip to content

fix(bump-v1): annotate the release tag before moving v1 - #21

Merged
MattFisher merged 3 commits into
mainfrom
fix/annotate-release-tag
Oct 7, 2026
Merged

MattFisher merged 3 commits into
mainfrom
fix/annotate-release-tag

Conversation

@MattFisher

Copy link
Copy Markdown
Contributor

Ports two changes from python-project-template that this template is missing. Both are already causing problems in the consumers.

Annotate the release tag (python-project-template 1.8.1)

v1 and v1.1.0 are both lightweight tags on ece6092. Copier reads a template's version through dunamai. With two lightweight tags on one commit, dunamai picks v1:

$ git checkout ece6092 && uvx dunamai from git --format '{base}'
1

So the weekly template update in llm-prices and logfile-upload rewrote _commit: v1.1.0 and _commit: v1.0.0 to _commit: v1. That rewrite is the whole diff on their chore/template-update branches. In the Python template the same setup made copier update fail with "Downgrades are not supported".

bump-v1.yml now annotates the release tag after its refusal checks and before it moves v1. The step is the Python template's, minus that repo's self-release path.

Name the Actions setting that template-update needs

The update workflow opens its PR with the default GITHUB_TOKEN, so it needs Allow GitHub Actions to create and approve pull requests. Neither consumer has it turned on. logfile-upload's first run (35599735536) pushed the branch and then failed with GitHub Actions is not permitted to create or approve pull requests. The README update section and the post-copy message now say so (the message only when use_template_update is on).

After merge

Cut v1.1.1 from the GitHub UI. The new step annotates v1.1.1, and v1 moves off ece6092. No hand-annotation of v1.1.0 is needed, because v1 won't share its commit any more.

Every later run in both consumers also fails at the push with stale info. That bug is in template-update.yml itself and has its own PR.

Testing

  • actionlint and zizmor --offline --persona=auditor are clean on bump-v1.yml.
  • Rendered the scaffold at HEAD with use_template_update on and off. The message shows the new paragraph only when it is on, and the trailing whitespace is unchanged from main.

🤖 Generated with Claude Code

MattFisher and others added 3 commits October 7, 2026 18:20
With v1 and the release tag both lightweight on one commit, dunamai
picks "v1" and copier reads the template version as 1. Port the
annotate step from python-project-template 1.8.1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MattFisher
MattFisher merged commit 4b19c19 into main Oct 7, 2026
3 checks passed
@MattFisher
MattFisher deleted the fix/annotate-release-tag branch October 7, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant