Repository navigation
fix(docs): make cross-guide links resolve and point GitHub links at master - #5
Merged
Merged
Conversation
…aster Docs pages render at /docs/<slug>/, so a relative ./other-guide/ link resolved to /docs/<slug>/other-guide/ and 404ed. Every cross-guide link now uses ../other-guide/, which keeps the site base path. Links into the Gameplane repo used blob/main and tree/main; its default branch is master. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UshpSigdLccuYZi7oFJX9y Signed-off-by: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Sorry @ValgulNecron, you've used your own review budget of 250,000 diff characters for the last 7 days.
You can request another review in 6 days and 23 hours by commenting @sourcery-ai review. Upgrade to get a review now.
Reviewer's GuideThis documentation-only change fixes 165 cross-guide links to account for trailing-slash routing and the Flow diagram for resolving cross-guide documentation linksflowchart LR
Source["Docs source link"] --> Route["Rendered page with trailing slash"]
Route --> Relative["../target-guide/"]
Relative --> Base["/gameplane-website/docs/target-guide/"]
Base --> Resolved["Guide resolves successfully"]
Flow diagram for documentation link verificationflowchart LR
Build["astro build"] --> Dist["Generated dist/docs pages"]
Dist --> Check["Resolve every href against dist/"]
Check --> Pass["Cross-guide and GitHub links verified"]
Check --> Exception["dashboard-tour remains unresolved"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
ValgulNecron
referenced
this pull request
in GameplanePanel/Gameplane
Sep 28, 2026
Moves website from 9e992a4 to ffefb29 (merge of ValgulNecron/gameplane-website#5): cross-guide docs links now resolve (../<slug>/ instead of ./<slug>/) and links into this repo point at master instead of main. Addresses both Greptile findings on this PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UshpSigdLccuYZi7oFJX9y Signed-off-by: Claude <noreply@anthropic.com>
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the two findings Greptile raised on ValgulNecron/Gameplane#520, the submodule bump to this site's HeroUI redesign.
/docs/<slug>/(withtrailingSlash: "always"). A relative./module-authoring/link on/docs/console-protocols/therefore pointed to/docs/console-protocols/module-authoring/.src/content/docs/*.mdx(markdown links andhref="./…") now use../<slug>/.../keeps the/gameplane-websitebase path, which an absolute/docs/…link would drop.Gameplane/blob/mainandGameplane/tree/main(security guide, CRD catalog, architecture, console protocols) now usemaster, Gameplane's default branch.Verification
astro buildsucceeds (93 pages).hrefon every builtdist/docs/**page againstdist/. The only link that still fails is/docs/dashboard-tour/:src/pages/docs/[slug].astrofilters that page out, but the sidebar, the docs index card, the previous/next links andinstallation.mdxall link to it. That one is left as it is here; it needs a separate decision.🤖 Generated with Claude Code
https://claude.ai/code/session_01UshpSigdLccuYZi7oFJX9y
Generated by Claude Code
Summary by Sourcery
Correct documentation navigation links and align repository references with Gameplane's default branch.
Bug Fixes:
/docs/<slug>/pages correctly while preserving the site's base path.masterbranch.Tests: