Skip to content

feat: module translations (spec 019 T090, T091) - #51

Draft
ValgulNecron wants to merge 3 commits into
mainfrom
claude/project-thread-awjqv0
Draft

ValgulNecron wants to merge 3 commits into
mainfrom
claude/project-thread-awjqv0

Conversation

@ValgulNecron

Copy link
Copy Markdown
Collaborator

Before: module bundles carry only the template text, so the dashboard can show module names, settings and actions only in English.

After: a module can ship locales/<tag>.json. build.sh pushes each file as its own OCI layer, CI checks every module that has locales, and Minecraft Java, Terraria and Valheim ship a generated locales/en.json that translators start from.

How: build.sh adds one layer per locales/<tag>.json except en.json, with media type application/vnd.gameplane.module.locale.v1+json and the file name as its title, so the operator finds it. The validate workflow runs i18n-check --module from the main repo on every module with a locales/ folder. The en.json files were generated with gp-module i18n extract, not written by hand. A new root README explains how to add a language.

Merge order: this needs GameplanePanel/Gameplane#668 merged into master first, because the CI step installs i18n-check from master. The root modules pointer is bumped only after this PR merges.

🤖 Generated with Claude Code


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

build.sh adds one layer per locales/<tag>.json (en.json excluded) with
media type application/vnd.gameplane.module.locale.v1+json. CI runs
i18n-check --module on every module that has a locales/ folder; that
step needs GameplanePanel/Gameplane#668 merged first.

Signed-off-by: Claude <noreply@anthropic.com>
…Valheim

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@ValgulNecron ValgulNecron self-assigned this Oct 12, 2026
@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

ValgulNecron commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator Author

validate fails at the new "Check module locales" step with github.com/GameplanePanel/gameplane@master ... does not contain package .../i18n/cmd/i18n-check. That is expected for now: the i18n/ module only exists on GameplanePanel/Gameplane#668, which hasn't merged yet. Commit 251da8f moves that step to the end so the existing build.sh and validate.py tests still run and report first. Once #668 is on master, a re-run of this job should pass with no further change. The PR stays a draft until then.


Generated by Claude Code

The locale check needs GameplanePanel/Gameplane#668 on master; running
it last keeps the build.sh and validate.py tests visible meanwhile.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants