Repository navigation
fix(web): remove doubled spacing in admin auth cards - #698
Merged
Merged
Conversation
Tailwind v4 space-y adds margin on top of the cards' own header padding and an extra mt-4, so the Authentication, Helm-seeded OIDC and role mapping cards ran 16-20px taller per gap than design frame uMiwd. With pixelmatch 8 (PR 648) that pushes uMiwd over its 4% visual-diff limit. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 21 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CI Report - 9059cdfrun 38643512816 - attempt 1 0 failed - 10 passed - 22 skipped - 22m54s elapsed Coverage
Changed
Slowest jobs
e2e buckets run
|
The content column started 8px below design uMiwd because PageHeader's pb-2 stacks on space-y-6, and the Helm-seeded OIDC provider rows were about 22px taller than the design. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
ValgulNecron
marked this pull request as ready for review
October 14, 2026 22:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: with pixelmatch 8 (Dependabot PR #648), the Admin settings authentication screen (design frame uMiwd) scores 5.17% against its 4% visual-diff limit. The same screenshot scores 2.55% under pixelmatch 7. The Authentication, Helm-seeded OIDC provider and Role mapping overrides cards are 16-20px taller per gap than the design.
After: those three cards follow the design's vertical spacing, so uMiwd should pass under pixelmatch 8 once #648 rebases onto this.
How: Tailwind v4
space-y-*puts a margin on siblings, which stacked with the cards' own header padding and an extramt-4. The cards now usespace-y-0, the duplicatemt-4is gone, the Helm card's rows are tighter, and the role divider gets the gap the design shows. Onlyweb/src/routes/AdminSettings.tsxchanges; no tests, design files or visual-diff script.🤖 Generated with Claude Code
Generated by Claude Code