Skip to content

test(e2e): pick the header Create link button in share-links spec #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ValgulNecron wants to merge 1 commit into from
Closed

test(e2e): pick the header Create link button in share-links spec #695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web/e2e/specs/live/share-links.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,13 +160,14 @@ test.describe("live: share links", () => {
// not because a dialog could be open yet here (none is), but so this
// stays correct even if a previous dialog's DOM lingers — the button text
// "Create link" is shared with the create dialog's own submit button.
// When the list is empty the page renders a second "Create link" (the empty-state CTA, ShareLinks.tsx), so take the header one with .first().
async function openCreateDialog(page: Page): Promise<Locator> {
const detail = new ServerDetailPage(page);
await detail.goto(serverName);
await expect(page.getByRole("heading", { name: serverName })).toBeVisible({ timeout: 20_000 });
await detail.clickTab("Settings");
await page.getByRole("tab", { name: /^share links$/i }).click();
await page.getByRole("main").getByRole("button", { name: "Create link" }).click();
await page.getByRole("main").getByRole("button", { name: "Create link" }).first().click();
const dialog = page.getByRole("dialog", {
name: new RegExp(`^create share link for ${serverName}$`, "i"),
});
Expand Down
Loading