Feature/maroon 603 convex hull3 d visualization - #607
Conversation
There was a problem hiding this comment.
Are these changes necessary?
If not, please revert them.
There was a problem hiding this comment.
Reverted to develop branch
There was a problem hiding this comment.
Please revert these changes, since your implementation is not related to VR.
There was a problem hiding this comment.
Reverted to develop branch
| List<HullUtils.Face> faces = new List<HullUtils.Face>(); | ||
|
|
||
|
|
||
| int[] initial = HullUtils.FindInitialTetrahedron(pts); |
There was a problem hiding this comment.
FindInitialTetrahedron() can return null.
Please handle this case before accessing the array to avoid a runtime exception.
There was a problem hiding this comment.
Added Null check
| List<HullUtils.Face> faces = new List<HullUtils.Face>(); | ||
|
|
||
|
|
||
| int[] initial = HullUtils.FindInitialTetrahedron(pts); |
There was a problem hiding this comment.
FindInitialTetrahedron() may return null. Please check before accessing its elements to avoid a runtime exception.
There was a problem hiding this comment.
Added Null check
| ctx.ClearHighlightLines(); | ||
| ctx.ResetHullFaceColors(); | ||
|
|
||
| ctx.CaptureStep(17); |
There was a problem hiding this comment.
Pseudocode lines contain only indices 0–16?
There was a problem hiding this comment.
Added Finish State for the convex hull algorithms
| Vector3 fc = visible[0].Center(pts); | ||
| ctx.UpdateSearchLine(pts[i], fc); | ||
|
|
||
| ctx.CaptureStep(5); |
There was a problem hiding this comment.
Please check the mapping between the algorithm operations and the pseudocode steps so that the highlighted pseudocode corresponds to the state being visualized.
The snapshot sequence does not seem to match the displayed pseudocode. For example, pseudocode line 5 describes removing the visible faces, while the actual removal happens later before CaptureStep(7)
There was a problem hiding this comment.
Updated Pseudo code logic/order
2 participants
Implementation of the Convex hull 3D visualization experiment - feature maroon 603
close #603