Fix: Add missing validators on DTO fields rejected by whitelist validatiib - #825
Merged
Conversation
dzikowski
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mint error is the third face of the #811 strict-whitelist rollout, but a new variant: this time it's not legacy state — it's a property that never had any class-validator decorator. Whitelist validation only recognizes properties that carry at least one validator decorator, so an undecorated property is "unknown" even on its own class.
FetchTokenMintConfigurationsResponse.results (chain-api/src/types/mint.ts) had only @jsonschema — no validator. The chaincode builds that response via createValidDTO, so every FetchTokenMintConfigurations call that returns a configuration has failed since #811 with exactly your screenshot's error: whitelistValidation: property results should not exist. I reproduced it in one line — even an empty results array throws. The "Use Mint Allowance" flow trips it because the JAPAN token has a mint configuration the UI fetches pre-mint; tokens without configurations wouldn't.
Fixes (uncommitted on fix/no-response-validation)