Skip to content

fix(appeng): correct lua index base and add backward compatibility - #211

Merged
Dream-Master merged 4 commits into
GTNewHorizons:masterfrom
hinyb:fix/appeng-essentia
Jul 25, 2026
Merged

fix(appeng): correct lua index base and add backward compatibility#211
Dream-Master merged 4 commits into
GTNewHorizons:masterfrom
hinyb:fix/appeng-essentia

Conversation

@hinyb

@hinyb hinyb commented Jul 24, 2026

Copy link
Copy Markdown

Summary

Changes:

  • correct appeng's lua apis to use 1-based indexing
  • add backward compatibility for thaumicenergistics
    • correct name to getTag
    • add support to pass aspect name directly

Checklist

  • I have tested this PR in DevEnv
  • I have tested this PR in Fullpack
  • This PR is in compliance with the GTNH AI Policy
  • This PR requires another PR in order to merge

@hinyb hinyb added the Bug Fix Fixes a bug. Please link it in the PR if an issue exists for it. label Jul 24, 2026

@Azusfin Azusfin left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks

@Dream-Master
Dream-Master merged commit 52c95fe into GTNewHorizons:master Jul 25, 2026
1 check passed
@hinyb
hinyb deleted the fix/appeng-essentia branch July 25, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Fixes a bug. Please link it in the PR if an issue exists for it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants