Fixed several bugs in TextFieldWidget - #159
Open
Spaghetti-OberNub wants to merge 1 commit into
Open
Conversation
MCTian-mi
added a commit
to SymmetricDevs/ModularUI
that referenced
this pull request
Aug 10, 2026
Adds empty-field guards, multiline paste fix, setText helpers and renderer cursor/mark bounds checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensureNotEmpty()toTextFieldHandlerand some bounds checks inTextFieldRenderer.subListtarget inTextFieldHandler.insert()when inserting >2 lines.wouldFit()height restriction for multiline fields(maxLines > 1), allowing editors to scroll properly beyond initial height.setText()methods toTextFieldHandlerandBaseTextFieldWidget.I would be thankful for some additional testing.
Checklist