Add publish_period and interval to SimulationArgs#206
Open
poorva1209 wants to merge 3 commits into
Open
Conversation
afisher1
requested changes
Jun 18, 2026
| duration: str = field(default="300") | ||
| timestep_frequency: str = field(default="1000") | ||
| timestep_increment: str = field(default="1000") | ||
| publish_period: str = field(default="60") |
Contributor
There was a problem hiding this comment.
interval is vague. timestep_interval or timestep_size would convey better meaning for users. A nice to have would be different defaults based off of run_realtime paramter. False: publish_period = 60, interval = 60. True: publish_period = 3, interval = 1. in fact interval must be 1 regardless if run_realtime is True.
…e error checking on some attributes to detect user errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.