Open
Conversation
takb
commented
Feb 20, 2026
takb
commented
- add parameter pod_ready_timeout to run() with default WAIT_TIMEOUT_FOR_READY, pass to consume_pod_logs()
- add parameter ready_timeout to consume_pod_logs() with default WAIT_TIMEOUT_FOR_READY, pass to wait_for_pod()
takb
pushed a commit
that referenced
this pull request
Mar 16, 2026
…ates (dagster-io#21188) ## Description I spent a while trying to track down https://linear.app/dagster-labs/issue/FE-1004/asset-graph-incorrectly-showing-unknown-for-nodes, and I have not been able to figure it out. This PR aims to improve the asset health statuses by distinguishing between three different "unknown" states that all render the same way, making it easier to track things like this down from user reports in the future: 1. `health === undefined`: Normal when the health system is still loading the data for this asset. We now show "Loading..." instead of "Unknown" while it's loading. 2. `health?.assetHealth === 'undefined'`: GraphQL issues, fallbacks in various callsites (see 8 occurrences of `health?.assetHealth ?? 'undefined`). This really should not be happening, and having it use a specific message is useful for bug reports. 3. `AssetHealthStatus.UNKNOWN`: The backend evaluated the asset and determined it has never been materialized or observed (This case is unchanged) The changes together make it easier to debug what is happening, and I think the missing loading state in particular was just an oversight when we built this. Overall, I don't think we should see case #1 (the new No Data message), and if we do, it narrows it down quite a bit. --------- Co-authored-by: Claude <noreply@anthropic.com> Synced-From-Internal GitOrigin-RevId: 65f86af7c2e95d353f1758c8ee84ffd99cc9e2fb
- add parameter pod_ready_timeout to run() with default WAIT_TIMEOUT_FOR_READY, pass to consume_pod_logs() - add parameter ready_timeout to consume_pod_logs() with default WAIT_TIMEOUT_FOR_READY, pass to wait_for_pod()
takb
force-pushed
the
fix/add-pod-ready-timeout
branch
from
eee89d1 to
286ae5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.