refactor(tools): close H1 manifest catalog baseline#794
Merged
limityan merged 1 commit intoMay 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-agent-tools.manifest_resolver,ToolRegistry, andGetToolSpecTool.Functional Boundary
ToolUseContext, workspace services, cancellation token, computer-use host, snapshot decorator, runtime unlock state, or GetToolSpec execution moved out of core.Review Notes
scripts/check-core-boundaries.mjsanchors so agent-tools can own only pure helper contracts while core still owns runtime assembly and execution anchors.Verification
rustfmt --edition 2024 --check src/crates/agent-tools/src/framework.rs src/crates/agent-tools/src/lib.rs src/crates/agent-tools/tests/tool_contracts.rs src/crates/core/src/agentic/tools/implementations/get_tool_spec_tool.rs src/crates/core/src/agentic/tools/manifest_resolver.rs src/crates/core/src/agentic/tools/registry.rsnode scripts/check-core-boundaries.mjscargo test -p bitfun-agent-toolscargo test -p bitfun-core registry_ --libcargo test -p bitfun-core manifest_ --libcargo test -p bitfun-core get_tool_spec --libcargo test -p bitfun-core pipeline_preserves_core_owned_tool_context_without_portable_runtime_leak --libcargo check --workspacecargo test --workspacegit diff --check