refactor(tools): harden H1 migration baselines#791
Merged
limityan merged 1 commit intoMay 19, 2026
Merged
Conversation
22d43cb to
fe724e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gcwing/mainand keep the PR as a single commit.GetToolSpecinsertion, and core-ownedToolExecutionContexttoToolUseContextruntime state propagation.GetToolSpecload-observation to collapsed-tool-name collection helper intobitfun-agent-tools; core still ownsToolUseContext.unlocked_collapsed_tools, execution message parsing, runtime manifest assembly,GetToolSpecTool, snapshot decoration, and concrete tools.Functional Boundary
bitfun-agent-toolsremains a lightweight contract/helper crate and must not own product tool runtime assembly or unlock state.Verification
rustfmt --edition 2024 --check src/crates/agent-tools/src/framework.rs src/crates/agent-tools/src/lib.rs src/crates/agent-tools/tests/tool_contracts.rs src/crates/core/src/agentic/execution/execution_engine.rs src/crates/core/src/agentic/tools/manifest_resolver.rs src/crates/core/src/agentic/tools/pipeline/tool_pipeline.rs src/crates/core/src/agentic/tools/registry.rsnode scripts/check-core-boundaries.mjsgit diff --check gcwing/main..HEADcargo test -p bitfun-agent-tools --test tool_contractscargo test -p bitfun-core registry_ --libcargo test -p bitfun-core manifest_ --libcargo test -p bitfun-core pipeline_preserves_core_owned_tool_context_without_portable_runtime_leak --libcargo test -p bitfun-core collects_unlocked_collapsed_tools_from_visible_get_tool_spec_results --libcargo check -p bitfun-core --features product-full