refactor(function-agents): wire commit facade path#781
Merged
limityan merged 2 commits intoMay 19, 2026
Merged
Conversation
Route Git commit-message generation through the product-domain runtime facade with core-owned Git and AI adapters, keep Startchat work-state on the existing path, and add boundary checks for the migration seam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FunctionAgentRuntimeFacadewhile keeping concrete Git and AI execution in core-owned adapters.PathBufinstead of lossy string paths.StartchatTimeSnapshotso future work-state wiring can preserve the existinganalyze_git=falsetime-info behavior.Functional Boundary
This PR is intended to be behavior-preserving. It does not move Git service execution, AI client selection, prompt templates, JSON extraction, error mapping, or Startchat work-state execution out of core. The only product call-path change is the Git commit-message orchestration now flowing through the product-domain facade with the same core adapters underneath.
Validation
cargo test -p bitfun-product-domains --no-default-featurescargo test -p bitfun-product-domains --features product-fullcargo check -p bitfun-core --features product-fullcargo test -p bitfun-core function_agents:: -- --nocapturenode scripts/check-core-boundaries.mjscargo tree -p bitfun-product-domains --no-default-features --depth 1 --edges featuresrustfmt --edition 2021 --check src\crates\core\src\function_agents\git-func-agent\commit_generator.rs src\crates\core\src\function_agents\port_adapters.rs src\crates\product-domains\src\function_agents\ports.rs src\crates\product-domains\tests\function_agent_contracts.rsgit diff gcwing/main...HEAD --check