refactor(product-domains): add runtime facade guardrails#779
Merged
limityan merged 1 commit intoMay 19, 2026
Merged
Conversation
Move MiniApp runtime state persistence behind product-domain facade contracts and add function-agent runtime facade/adapter boundaries without rewiring product execution paths. Update decomposition guardrails and module AGENTS docs to keep runtime migration constraints explicit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Functional Boundary
This PR is intended to be behavior-preserving. It does not move MiniApp worker/runtime execution, built-in MiniApp update logic, function-agent product call paths, tool runtime ownership, or product-surface UI/protocol behavior. The code changes focus on ownership seams and regression coverage around existing behavior.
Validation
node scripts/check-core-boundaries.mjscargo test -p bitfun-product-domains --no-default-featurescargo test -p bitfun-product-domains --features product-fullcargo check -p bitfun-core --features product-fullcargo test -p bitfun-core miniapp::manager::tests -- --nocapturecargo test -p bitfun-core function_agents:: -- --nocapturecargo tree -p bitfun-product-domains --no-default-features --depth 1 --edges featuresgit diff upstream/main --check