feat: 캘린더 일정에서 detatil 부분을 i18n에 포함 - #41
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough체크리스트 항목의 detail에 대한 다국어 저장·검증을 추가하고, 프롬프트 지침을 확장한 뒤 서비스에서 자동으로 detailI18n 값을 채우도록 구현했습니다. Changes체크리스트 Detail 다국어 지원
🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/services/newsletter_prompt.py`:
- Around line 36-41: The schema CHECKLIST_ITEM_SCHEMA currently requires
detailI18n but the system prompt in newsletter_prompt.py doesn't instruct the
LLM to always produce checklistItems[].detailI18n, causing validation failures;
update the system prompt text to explicitly instruct the model to include a
detailI18n field for every checklist item (even if empty/null) in
checklistItems[] or else change CHECKLIST_ITEM_SCHEMA to allow missing
detailI18n—modify the prompt generation logic that constructs the
system/instruction string and reference CHECKLIST_ITEM_SCHEMA, detailI18n, and
checklistItems[] so outputs always match the schema.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 2e13e4af-9a8e-4a60-8b44-faafa12676db
📒 Files selected for processing (3)
app/schemas.pyapp/services/newsletter_extractor.pyapp/services/newsletter_prompt.py
📌 작업 요약
🌿 브랜치 정보
feat/#40-faq-and-detatildevelop(기본)✅ 체크리스트
feat/refac/hotfix/chore/design/bugfix)feat/fix/refactor/docs/style/chore)Summary by CodeRabbit