fix: Watcher not updating on file change - #342
Open
ALameLlama wants to merge 3 commits into
Open
Conversation
Collaborator
|
Replace final schedule call with following: vim.schedule(function()
if not watch_state[buf_id] then return end
if vim.bo[buf_id].modified then return end
local pending = state.pending_refresh
state.pending_refresh = nil
pcall(function() instance:refresh(pending) end)
end)Because I want it return before setting pending refresh to nil. |
Contributor
Author
|
Sounds good, I'll update this on the weekend and test it out |
ALameLlama
force-pushed
the
fix/watcher-not-always-updating
branch
2 times, most recently
from
July 12, 2026 09:30
331a437 to
c503c43
Compare
Contributor
Author
|
Can you hold off on merging this? I've noticed I'm getting a weird flashing only on hidden files. I'll need to look into what is causing this |
ALameLlama
marked this pull request as draft
July 12, 2026 09:34
ALameLlama
force-pushed
the
fix/watcher-not-always-updating
branch
from
August 7, 2026 06:40
1df77e3 to
abb5087
Compare
Contributor
Author
I think the CI is just failing again due to performance? |
ALameLlama
marked this pull request as ready for review
August 7, 2026 06:43
Contributor
Author
|
Sorry for the delay on this but the issue seemed to be since both shared a namespace it would updated and clear it causing a flashing issue, adding cache and a separate namespace. if you have a better way to handle this I'm all ears :) |
Collaborator
|
Sure tell you when I got free |
Contributor
Author
|
take your time, I'll keep playing around with it and update you if I notice anything else weird |
1 task
Since this was sharing a namespace with the highligh namespace, updates to that would clear the git icons until the git watch was done causing a flashing effect. added separate namespace and cache so they don't flash
ALameLlama
force-pushed
the
fix/watcher-not-always-updating
branch
from
August 8, 2026 07:04
abb5087 to
d862f89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the watcher doesn't always update the git status without reopening fyler, I mostly noticed this when editing files or adding new files.
Before:
Screencast_20260704_133548.webm
After:
Screencast_20260704_133913.webm