Implement hscriptPos to be fully built in#402
Closed
VirtuGuy wants to merge 1 commit into
Closed
Conversation
VirtuGuy
force-pushed
the
remove-hscriptpos
branch
from
81457ea to
6e1c52b
Compare
|
hscriptPos should be kept, as it makes polymod not to be bloated and slow from traces, you dont always need the trace pos in some projects. |
Author
|
Member
|
Agreed tbh. It shouldn't error if it's disabled but also it should be opt-in since there's technically a performance impact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the need for
hscriptPosin order for line numbers to be used in script errors.hscriptPosdoesn't need to be something you have to manually enable. In fact, you probably never want it disabled, because why wouldn't you want line numbers??This should also put an end to PRs having to be made due to any compiling problems that occur because of
hscriptPosbeing disabled.