Skip to content

fix(Outreach): use shutil.which, close SMTP, safe file removal, csv.reader#240

Open
tatenda-source wants to merge 1 commit intoFujiwaraChoki:mainfrom
tatenda-source:fix/outreach-go-smtp-csv
Open

fix(Outreach): use shutil.which, close SMTP, safe file removal, csv.reader#240
tatenda-source wants to merge 1 commit intoFujiwaraChoki:mainfrom
tatenda-source:fix/outreach-go-smtp-csv

Conversation

@tatenda-source
Copy link
Copy Markdown

Summary

  • Use shutil.which("go") instead of unreliable os.system("go version")
  • Close yagmail SMTP connection in finally block
  • Add os.path.exists guard before os.remove("niche.txt")
  • Use csv.reader instead of naive split(",") for proper CSV parsing

Closes #228

Test plan

  • Verify Go detection works correctly
  • Verify SMTP connection is closed after email sending
  • Test with CSV containing quoted fields

🤖 Generated with Claude Code

…eader

Closes FujiwaraChoki#228

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(Outreach): unsafe Go check, SMTP leak, unsafe file removal, naive CSV parsing

1 participant