fix: update moviepy crop import for v2 compatibility#193
Open
AdityaVikramSingh19 wants to merge 3 commits intoFujiwaraChoki:mainfrom
Open
fix: update moviepy crop import for v2 compatibility#193AdityaVikramSingh19 wants to merge 3 commits intoFujiwaraChoki:mainfrom
AdityaVikramSingh19 wants to merge 3 commits intoFujiwaraChoki:mainfrom
Conversation
The old import `from moviepy.video.fx.all import crop` is broken in moviepy v2. Updated to `from moviepy.video.fx import Crop as crop` to fix the ModuleNotFoundError.
In moviepy v2, crop() can no longer be called as a standalone function. Updated both crop() calls in combine() to use the new clip.with_effects([Crop(...)]) syntax.
- Replaced set_fps() with with_fps() for moviepy v2 compatibility - Replaced .fx(afx.volumex, 0.1) with .with_effects([afx.MultiplyVolume(0.1)]) for moviepy v2 compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
from moviepy.video.fx.all import cropthrows a ModuleNotFoundError in moviepy v2 because the module structure changed.Fix
Updated the import to
from moviepy.video.fx import Crop as cropwhich works with moviepy v2.Fixes #117