Fix Selenium/MoviePy dependency compatibility#192
Open
TTAWDTT wants to merge 2 commits intoFujiwaraChoki:mainfrom
Open
Fix Selenium/MoviePy dependency compatibility#192TTAWDTT wants to merge 2 commits intoFujiwaraChoki:mainfrom
TTAWDTT wants to merge 2 commits intoFujiwaraChoki:mainfrom
Conversation
…bility - Remove unused selenium_firefox import from Twitter, YouTube, and AFM classes (selenium_firefox 2.0.8 is incompatible with Selenium 4.x - FirefoxBinary was removed) - Lock selenium to version 4.10.0 for stable Selenium API compatibility - Lock moviepy to version 1.0.3 for API compatibility (2.2.1 restructured the API) - Remove selenium_firefox from requirements.txt These changes resolve ModuleNotFoundError issues and ensure consistent dependency versions across environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selenium_firefoximports from the Firefox automation classesmoviepy==1.0.3withPillow==9.5.0to keep the current MoviePy v1 code path workingWhy
selenium_firefoxis not needed anymore and conflicts with modern Seleniummoviepy 1.0.3andPillow 10+are an incompatible combination for the current resize/subtitle flowrequestsis used directly in the codebase and should be declared explicitlyValidation
python -m compileall src scriptspip install -r requirements.txtpip checkmoviepyImageClip(...).resize(...)pathpython scripts/preflight_local.py(fails only for local Ollama availability and missing Gemini/Nano Banana API key)