Add ICMP socket syscall support for toybox ping#50
Merged
pradosh-arduino merged 1 commit intoJul 5, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ping) can send/receive ICMP using the kernel networking stack.wgetwhen HTTPS/TLS is not available while leaving TLS implementation for a later change.Description
fd_create_virtualto the stream layer to allocate virtual file-descriptor slots for kernel-backed objects. (source/kernel/C/stream.c,source/includes/stream.h).sendto,recvfrom, andsetsockopt, and added protocol/errno constants required for the minimal socket implementation. (source/includes/syscalls.h).sys_socket,sys_sendto,sys_recvfrom,sys_setsockopt, and cleanup onclose; added a small in-kernel socket table and sockaddr struct to map virtual FDs to the ICMP ping implementation. The new syscalls are wired into the syscall dispatcher and syscall name table. (source/kernel/C/syscalls.c).wgetusage/help and error messaging to clearly indicate that HTTPS/TLS requires TLS support which is not linked/implemented yet. (source/kernel/C/shell/commands/wget.c).Testing
git diff --check, which reported no whitespace/format issues and completed successfully.make -C sourcewhich compiled source files and reached the final link step; compilation of translation units succeeded but the final link failed because the environment lacked generated/version symbols (versions/date) required by the build system.makewhich failed during ISO staging because required prebuilt/staged artifacts (kernel ELF and Limine files) are not present in this environment; these failures are environmental and not caused by the introduced code.Codex Task