Skip to content

🧪 [testing improvement] Add unit tests for Sync Server endpoints - #47

Open
FrogletApps wants to merge 1 commit into
mainfrom
test/sync-server-endpoints-4337540522757209394
Open

🧪 [testing improvement] Add unit tests for Sync Server endpoints#47
FrogletApps wants to merge 1 commit into
mainfrom
test/sync-server-endpoints-4337540522757209394

Conversation

@FrogletApps

Copy link
Copy Markdown
Owner

🧪 Add unit tests for Sync Server endpoints (/api/sync/pull and /api/sync/push)

🎯 What: The testing gap for sync server endpoints in server/src/core/app.ts addressed using Node's native test runner and Hono's app.request().

📊 Coverage:

  • GET /api/sync/pull:
    • Returns 400 error when sku query parameter is missing.
    • Returns empty array and version 0 when no notes exist.
    • Filters incident notes based on since version parameter and correctly calculates latestVersion.
  • POST /api/sync/push:
    • Returns 400 error when sku parameter is missing in payload.
    • Returns 400 error when changes is not an array.
    • Successfully applies note changes, returns latestVersion and appliedCount, and persists changes in storage.

Result: Enhanced sync server test coverage and reliability with fast, zero-dependency unit tests running via Node's native test runner.


PR created automatically by Jules for task 4337540522757209394 started by @FrogletApps

- Add test suite in server/test/sync.test.ts using node:test and Hono app.request()
- Implement MockStorageAdapter for endpoint testing isolation
- Cover GET /api/sync/pull (missing SKU, filtering by version, version calculation)
- Cover POST /api/sync/push (invalid payload format, successful notes push)
- Add "test" script to server/package.json

Co-authored-by: FrogletApps <17247396+FrogletApps@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant