Repository navigation
fix(semantic): stop model reservations at the time deadline - #520
JohnnyWilson16 merged 2 commits into
Conversation
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
JohnnyWilson16
left a comment
JohnnyWilson16
left a comment
There was a problem hiding this comment.
LGTM! Changing the boundary to elapsed >= max_seconds cleanly fixes the zero-budget race. Deterministic monkeypatched clock tests and pipeline call-count assertions look great. Ready to merge.
…udget-boundary Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com> # Conflicts: # CHANGELOG.md
|
Refreshed with current main after #518 merged and resolved the changelog conflict while retaining both fixes. The updated branch passes 77 focused checks, Ruff, and mypy. The full fast suite has 7,621 passes and 95.00% coverage; its zero-budget failure is gone, leaving only the four previously reproduced Windows baseline failures. Hosted CI is running on 04cf259 before I mark this dependency draft ready. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 participants
A zero-second model budget can still reserve a model call when the monotonic clock has not advanced: elapsed time equals the limit, but the old check only stops when elapsed is greater. Stop reservations at
elapsed >= max_secondsso calls cannot begin at an exhausted deadline. Positive remaining budgets retain their existing behavior, and the optional-model documentation describes the boundary.Validation: 77 focused semantic-budget and Polars parity checks pass after refreshing with current main, including deterministic clock boundary cases and pipeline call-count coverage. The full fast suite has 7,621 passes, 49 skips, and 95.00% coverage; the zero-budget failure is fixed, leaving four reproduced Windows baseline failures (performance-runner timeout, console encoding, generated-code filename escaping, and CSV newline round trip). Ruff, Linux-targeted mypy across 205 source files, and diff checks pass.
Refreshed after #518 merged and resolved the changelog conflict by retaining both fixes. All hosted checks pass on the refreshed head, including the required quality-fast lane and floating Python 3.9–3.13 matrix.