test(experts): pin every entry of the number-word and month-name tables

[kevincostner17]

Why

Mutation testing of semantic/experts.py left 98 numeric-constant survivors. Classified by syntactic context, only 7 are operands of a comparison — the thresholds a mutation brief usually cares about. 45 are dict values, and they are two lookup tables:

• the spelled-number map (_ONES / _TENS / _BIG), used by parse_number_words
• the month-name map (_MONTHS), used by _resolve_date

Only 10 of the 30 number words appeared anywhere in tests/, and no month name did, so changing "seven": 7 to 8 or "march": 3 to 4 broke nothing.

Neither table is wrong today. The gap is that a typo in either would ship as a wrong value, silently: spelled numbers converting to the wrong integers, or "14 March 2021" written as April 14th and reported as an unambiguous, low-risk, auto-appliable repair.

What

tests/test_lookup_tables.py — 91 tests, test-only:

• every number word → its own value; every scale word, bare and with a count
• every tens word composed with every unit, spaced and hyphenated
• every month name, in both orderings the pattern accepts, and upper-case
• a month-name date is never reported ambiguous and ignores dayfirst
• an unknown token or month name still makes the whole phrase a non-match

Every expectation is written out literally. Deriving it from the table under test would make the test agree with any table, including a broken one.

Verification

• 91 passed on py3.12 / pandas 2.3.3 and py3.9 / pandas 1.5.3
• 238 passed on each of 5 pytest-randomly seeds together with test_experts_date_mutants.py and test_semantic_cleaning.py
• Five table entries corrupted by hand (seven, march, ninety, thousand, dec) — each is caught
• Rebased onto Add synthetic financial ledger fixture with accounting negatives (#496) #503, which changed experts.py but not the tables; re-verified there

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 28c0863f-daca-4966-8a4f-bd90be7970da

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}