fix(plugins): isolate malformed plugins and proposals, warn on duplicate names, honour late network opt-in

[kevincostner17]

Summary

Fixes three plugin-registry bugs in src/freshdata/plugins.py.

• Plugin failures escape isolation: bad proposals or a malformed entry point break the run #297 Plugin failures escaping isolation
  • Proposals for a column the plugin was not given (an expert's own column, or a backend's frame) are dropped and logged once per plugin, instead of raising KeyError in apply.
  • The provenance merge is guarded, so a malformed proposal is dropped with a log message.
  • _max_risk falls back to the documented "high" default for non-string or unhashable values.
  • Each entry point is loaded and registered inside its own try, so one malformed entry point is skipped and the rest of its group still registers.
  • Plugins raising in propose() stay isolated.
• Duplicate plugin names are replaced silently; docs promise a warning #298 Duplicate plugin names: reusing a name within a kind logs a WARNING naming the replaced and replacing plugin. The last registration still wins, as documented. Re-registering the same object is silent.
• FRESHDATA_ALLOW_NETWORK_PLUGINS set after registration never activates the plugin #299 Late network opt-in: network plugins registered without allow_network=True are marked network_blocked. Every registry accessor re-reads FRESHDATA_ALLOW_NETWORK_PLUGINS at call time, so setting the variable after registration activates the plugin. Without it, network plugins stay inactive (offline by default is unchanged). A missing dependency still keeps a plugin inactive.

docs/plugins.md now covers dropped off-target or malformed proposals, entry-point skipping, the duplicate-name warning, and when the environment variable is read.

Behaviour changes

• Off-target or malformed proposals are dropped with a log message instead of crashing the clean.
• Unsetting FRESHDATA_ALLOW_NETWORK_PLUGINS later also turns an env-enabled network plugin off again; plugins registered with allow_network=True are unaffected.
• Reusing a plugin name within one kind logs a WARNING (via logging, as the module already does).

Tests

New tests/test_plugin_isolation.py:

• Each issue's reproduction.
• Wrong-column and malformed-provenance proposals are dropped and the clean completes; the wrong-column warning is logged once across columns and runs.
• Backend off-frame proposals are dropped.
• A raising propose() stays isolated.
• Unhashable max_risk falls back to "high".
• A malformed entry point is skipped while the next one registers.
• The duplicate-name warning is checked with caplog, including the same-object and cross-kind cases.
• Setting the variable late activates a plugin (experts, backends, entry points); network plugins stay inactive without it, or with values other than 1; unsetting it deactivates env-gated plugins; allow_network=True does not depend on the variable; missing dependencies still win.

Verification

• ruff check .: passed. mypy src/freshdata: no issues.
• pytest -m "not online and not large":
  • py3.12: 4268 passed, 6 skipped
  • py3.9: 4264 passed, 10 skipped
• Plugin contract job steps (tests/test_plugins.py and example plugin contracts): passed.

Closes #297
Closes #298
Closes #299

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: dbff5c0e-4ace-4690-822a-09877fcff907

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

FreshData benchmark report — performance

• freshdata: ?
• python: ?
• platform: ?

fixture	n_rows	n_cols	p50 s	p95 s	peak MB	repair %	false-repair %	preserve %	trust	monotonic	export %

Authored-code reduction (Metric 6)