data_model: resync the vendored backend types - #238
Merged
Merged
Conversation
The drift gate compares shard_core/data_model/backend against freeshard-controller main byte for byte, and it has been red since at least 2026-08-17. Controller 0.27.0 rebuilt settings as a key-by-cloud matrix, which is the whole of the remaining difference: SettingsSpec as the type authority, the flattened schema entry, and the removal of the type column. Generated by `just get-types`. Nothing in shard_core imports settings_model, and annotated_types arrives with pydantic, so this only satisfies the gate. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VWEj4ivtnwGLef4hb5eFTm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks #237, and fixes the drift gate for everyone else on the way.
What
shard_core/data_model/backendis a byte-for-byte copy of freeshard-controller'sdata_model, checked by theBackend types drift checkworkflow. It has been red since at least 2026-08-17 — the last two runs onmainthat day both failed, and it has not run green there since.The entire remaining difference is
settings_model.py, from controller 0.27.0, which rebuilt settings as a key-by-cloud matrix:SettingsSpecas the single type authority, a flattenedSettingSchemaEntrycarryingge/ledirectly,PER_CLOUD_KEYS, and the removal of thetypecolumn along withSetting.__int__/__bool__/__float__.Generated with
just get-typesagainst freeshard-controllermainat28c8b32. No hand edits.Why it is safe
settings_model. Greppingshard_core/andtests/outside the vendored directory returns nothing, so this changes no behaviour.annotated_typesimport resolves — it is a pydantic dependency, present in the lockfile already. Verified by importing the vendored module and readingSettingsSpec,SettingKey,SettingScopeandvalidate_setting_valueoff it.Note
I pulled the local freeshard-controller checkout before generating: it was 57 commits behind
origin/main, andget-typescopies from the working tree, so regenerating against a stale checkout would have vendored the wrong thing and looked like it worked.🤖 Generated with Claude Code
https://claude.ai/code/session_01VWEj4ivtnwGLef4hb5eFTm