Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a binary package, libreac-tests (the same name on Fedora and Debian), that carries fake_box, the software REAC stagebox, in /usr/libexec/libreac/tests. It is linked from libreac's own objects, so it needs nothing but libc and no other libreac package.
Why: reac-pw's test workflow clones libreac at a pinned tag and builds fake_box from source, because nothing shipped it. Under the no-pins ruling a library builds against the published packages of its dependencies (FreeREAC/reac-pw#23). This is the change it waits for.
Changes: the spec subpackage and a build step for fake_box, debian/control, debian/libreac-tests.install and the matching lines in debian/rules, and a CI job that builds the RPMs and checks the new package's file list and that it requires no libreac package.
Checked: rpmbuild -ba on fedora:44 on h2 (the %check suite runs); libreac-tests lists exactly fake_box and its licence and requires only libc and libm. The Debian build of the same change is run by the release dry run of this PR.
Not done here: no version bump. The package first exists in the next release; reac-pw will ask for libreac >= 1.7.2, < 1.8, which is the number of a packaging-only patch release. If the release is numbered otherwise, reac-pw's floor follows it.