Skip to content

Quality of life improvements and new features - #4

Open
freeman401 wants to merge 3 commits into
FranceBB:masterfrom
freeman401:master
Open

freeman401 wants to merge 3 commits into
FranceBB:masterfrom
freeman401:master

Conversation

@freeman401

Copy link
Copy Markdown

No description provided.

Quality of life improvements. High contrast waveform mode. Chroma targets. Better color matrix handling.
Added new parameters
@FranceBB

Copy link
Copy Markdown
Owner

I see what you're trying to do. I would even accept the new defaults being true for ChromaTargets, but I'm not really sure about HiConWave as I think it should at the very least be false.

ColorBars(pixel_type="YV24")

new=VideoTek2()
old=VideoTek()

StackVertical(new, old)

shows

image

as you can see, after going through

	if (HiConWave) {
		hcluma = luma.Crop(0,20,0,220).Levels(16, 2.0, 128, 0, 255, coring=false)
		luma = Overlay(luma, hcluma, 0, 20)
	}

the steps change completely (see the bottom being now one).

Setting HiConWave to false makes the bottom match the original version

ColorBars(pixel_type="YV24")

new=VideoTek2(HiConWave=false)
old=VideoTek()

StackVertical(new, old)
image

The whole point of a waveform monitor should be to represent what is in the picture exactly, so I'm not really sure about HiConWave. I can be fine with it, but only if it defaults to false.

Last but not least, I would prefer to have the Rec. info at the bottom and next to the chroma circle as optional like under a verbose info parameter. I like it, don't get me wrong, but the original idea behind this was to mimic what the Tektronix I have in the office was doing.

image

which doesn't show it by default

image image

and it's also better not to display it when you're working with log like Slog3 Sgamut3 'cause it gives the "false" impression that it's BT709 etc.

@FranceBB FranceBB self-assigned this Sep 16, 2026
@freeman401

Copy link
Copy Markdown
Author

Yes, the default behavior probably shouldn't be changed, despite the introduction of new settings.

I only disagree on one thing. If the chroma targets are displayed, the user definitely should know at all times which ones they're working with. Lack of clear labeling is as bad as false impression. For example, in your case above ColorBars(pixel_type="YV24") actually supplies wrong matrix metadata and consequentially the wrong targets are displayed.

New settings default to the old behavior. 
Improved color matrix detection for HDR UHD. 
New setting to ignore existing matrix metadata and assume matrix from the resolution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants