Repository navigation
Conversation
get_current_packet_header() and get_current_packet() describe the outermost packet. For a connection inside GENEVE, VXLAN, GRE, etc. that is the tunnel's IP/UDP header, so rph?$tcp is false. JA4T bailed out in new_connection before recording the SYN, and JA4L never armed its SYN-ACK and ACK thresholds, leaving ja4t, ja4ts, ja4l and ja4ls empty for every inner connection. Take the handshake data from events that Zeek builds from the inner headers: - JA4T/JA4TS: window size comes from connection_SYN_packet, and option kinds, MSS and window scale come from tcp_options. The two events fire separately for the same packet, so whichever arrives first parks its data and the other claims it by packet timestamp. SYN-ACK retransmit delays come from responder SYN events, and the -R suffix comes from connection_reset with a responder RST in history. The LINK_ETHERNET restriction no longer applies. - JA4L: SYN/SYN-ACK timestamps and both TTLs come from connection_SYN_packet. ssl_server_hello checks the connection's transport protocol, not the outer header. Behavior changes for non-tunneled traffic: - ECN SYNs (SYN|ECE|CWR) now produce a JA4T. - JA4L no longer writes ja4l_c when the client's second packet arrives without a SYN-ACK having been seen. Known gaps: JA4L's F timestamp needs per-packet payload length, which is unavailable for tunneled connections, so it is skipped there and ja4l_delta stays empty. JA4SSH and the QUIC JA4L TTL still read the raw packet header. Remove the JA4::parse_tcp_options BiF and src/ja4t.cc, which nothing calls anymore. JA4T is now pure script. Fixes FoxIO-LLC#324 Performance benchmarking tests to see how this impacts performance is the next step before I submit this PR. Signed-off-by: Seth Grover <seth.d.grover@gmail.com>
Signed-off-by: Seth Grover <seth.d.grover@gmail.com>
Signed-off-by: Seth Grover <seth.d.grover@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #324. From my comment there: