[cross-schema] Wire secondary-schema stores into the execution context at connection time - #4444
Draft
arnaud-lacurie wants to merge 2 commits into
Draft
Conversation
Closed
2 tasks
arnaud-lacurie
force-pushed
the
apple/arnaud-lacurie/cross-schema/pr3
branch
from
August 14, 2026 16:48
1100028 to
f32e4bc
Compare
arnaud-lacurie
changed the title
… time TransactionBoundDatabase now populates storesBySchemaName from the additional stores map on RecordStoreAndRecordContextTransaction, so that loadRecordStore(schemaId) can return the secondary FDBRecordStoreBase that RecordQueryStoreBindingPlan looks up at execution time.
Checkstyle/PMD RedundantImport: already imported above.
arnaud-lacurie
force-pushed
the
apple/arnaud-lacurie/cross-schema/pr3
branch
from
August 14, 2026 18:50
f32e4bc to
88e6a54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RecordStoreAndRecordContextTransactionnow carries a map of secondaryFDBRecordStoreBaseinstances keyed by schema name, populated by the connection layer when a cross-schema query is preparedTransactionBoundDatabase.loadRecordStore(schemaId)looks up the secondary store map before falling back to the primary store, soRecordQueryStoreBindingPlan.executePlanfinds the correct store at runtimeBackingRecordStore.fromTransactionAndStorefactory method to construct aBackingRecordStorewrapping an existingFDBRecordStoreBaseTest plan