Add percent-change histogram to metrics diff report - #4247
Merged
arnaud-lacurie merged 7 commits intoAug 24, 2026
Conversation
📊 Metrics Diff Analysis ReportSummary
ℹ️ About this analysisThis automated analysis compares query planner metrics between the base branch and this PR. It categorizes changes into:
The last category in particular may indicate planner regressions that should be investigated. Only Metrics ChangedThese queries experienced only metrics changes without any plan changes. If these metrics have substantially changed, Total: 16 queries Statistical Summary (Only Metrics Changed)
There were no queries with significant regressions detected. Minor Changes (Only Metrics Changed)In addition, there were 16 queries with minor changes. |
…togram" This reverts commit 7ae9557.
robert-brunel
requested changes
Jun 17, 2026
- Compute hi as (floor(last/binWidth)+1)*binWidth so it's always > lo, removing the need for the lo==hi edge-case check - Extract BIN_WIDTH/BAR_WIDTH as constants instead of local magic numbers - Size the Range column from the widest rendered bin label instead of a hardcoded width - Split appendHistogram into computeHistogramBins/formatHistogram statics - Rename sortedPcts to pcts in MetricsStatistics (not yet sorted there)
Move BIN_WIDTH/BAR_WIDTH constants to the top of MetricsAnalysisResult alongside the other fields instead of mid-class before appendHistogram.
arnaud-lacurie
marked this pull request as ready for review
August 24, 2026 09:32
robert-brunel
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appends a text histogram of the % change distribution to each field's stats block in the metrics diff report.
MetricsStatistics: collect percent diffs per field inBuilder, expose as sortedFieldStatistics.sortedPercentDiffsMetricsDiffAnalyzer: render a 2%-wide bin bar chart after each field summary; guard againstlo == hiedge case (all values identical on a bin boundary)