-
Notifications
You must be signed in to change notification settings - Fork 16
feat(reactjs-todo-davinci): add ValidatedPasswordCollector support #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ryanbas21
wants to merge
6
commits into
main
Choose a base branch
from
feat/validated-password-collector
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cf50b48
feat(reactjs-todo-davinci): add ValidatedPasswordCollector support
ryanbas21 aaf99e7
fix: use clientId URL param to select 356a254c tenant for ValidatedPa…
ryanbas21 ddb0906
docs(reactjs-todo-davinci): add ValidatedPasswordCollector to support…
ryanbas21 ee12bf3
fix(e2e): harden protect tests for null payload handling
ryanbas21 550a5b7
fix(e2e): resolve Playwright ESM config issue for journey app
ryanbas21 17d4a80
refactor: address PR comments on ValidatedPasswordCollector
ryanbas21 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
javascript/reactjs-todo-davinci/e2e/davinci-validated-password.spec.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /* | ||
| * | ||
| * Copyright (c) 2025 - 2026 Ping Identity Corporation. All rights reserved. | ||
| * This software may be modified and distributed under the terms | ||
| * of the MIT license. See the LICENSE file for details. | ||
| * | ||
| */ | ||
| import { test, expect } from '@playwright/test'; | ||
|
|
||
| const BASE_URL = 'http://localhost:8443'; | ||
| const ACR_VALUE = '769eecb92f8e66f88005a85e8b939a01'; | ||
|
|
||
| async function navigateToRegistrationForm(page) { | ||
| await page.goto(`${BASE_URL}/login?acrValue=${ACR_VALUE}`); | ||
| await expect(page.getByRole('heading', { name: 'Select Test Form' })).toBeVisible(); | ||
| await page.getByRole('link', { name: 'USER_REGISTRATION' }).click(); | ||
| await expect(page.getByRole('heading', { name: 'Example - Registration 1' })).toBeVisible({ | ||
| timeout: 10000, | ||
| }); | ||
| } | ||
|
|
||
| test.describe('React - DaVinci ValidatedPasswordCollector', () => { | ||
| test('shows password requirements list', async ({ page }) => { | ||
| await navigateToRegistrationForm(page); | ||
| await expect(page.locator('ul.password-requirements')).toBeVisible(); | ||
| await expect(page.locator('ul.password-requirements li').first()).toBeVisible(); | ||
| }); | ||
|
|
||
| test('shows inline validation errors for a password that violates policy, then clears them', async ({ | ||
| page, | ||
| }) => { | ||
| await navigateToRegistrationForm(page); | ||
| const passwordInput = page.getByLabel('Password'); | ||
| await passwordInput.fill('a'); | ||
| await expect(page.locator('[class$="-error"] li').first()).toBeVisible(); | ||
|
|
||
| await passwordInput.fill('Demo_12345!'); | ||
| await expect(page.locator('[class$="-error"] li')).toHaveCount(0); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything blocking the user from submitting the form if there is an error? Or are these just UI hints?