Frontmatter: locale/currency cleanup and template placeholders - #22
Conversation
Resolve a schema/rendering mismatch and add a reuse-first template story. (1) Remove the dangling document-default-currency lookup and reword document-locale to the render-time active locale; formatting is presentation, no new frontmatter fields. (2) Note that identification_number is the reserved field name for any party type (optional for natural persons). (3) Add spec 3.10 permitting placeholder directives as quoted frontmatter values for templates/drafts, reusing the existing placeholder mechanism; add validation row and LLM-reference notes. New CHANGELOG chapter added. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
⚠️ Not ready to approve
There are a couple of documentation accuracy issues in the new spec text that could mislead implementers (notably wording/cross-references in the new/updated sections).
Pull request overview
This PR updates the LegalDown specification and its LLM reference to clarify that locale/currency formatting is render-time configuration (not frontmatter), standardize identification_number as the reserved party identifier field across party types, and allow reuse-first template/draft authoring by permitting {{placeholder:}} directives as quoted frontmatter values.
Changes:
- Add spec §3.10 to allow
{{placeholder:}}in frontmatter value fields (quoted YAML strings) for templates/drafts, plus corresponding validation guidance. - Clarify locale/currency behavior: “active locale” is render-time; no document-level default currency (currency remains per
{{money:}}directive). - Document
identification_numberas the reserved cross-party field name (optional fornatural_person).
File summaries
| File | Description |
|---|---|
| spec/legaldown-spec.md | Adds §3.10 frontmatter placeholders, clarifies identification_number, and updates locale/currency wording and validation rules. |
| llm/legaldown-spec-llm.md | Mirrors the spec clarifications for LLM-oriented guidance (placeholders in frontmatter, reserved identification_number, validation notes). |
| CHANGELOG.md | Adds an Unreleased entry documenting the locale/currency cleanup and frontmatter placeholder support. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 2
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…e/wording issues Add locale to the style-template settings list (13.7) so the 10.1 cross-reference is accurate; reword the 10.1 note accordingly. Clarify in 3.10 that only party names (not side names) are referenced by the party directive. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
✅ Ready to approve
The changes are internally consistent across the spec, LLM reference, and changelog, with no verified correctness or formatting issues in the modified sections.
Note: this review does not count toward required approvals for merging.
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0 new
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
Resolve a schema/rendering mismatch and add a reuse-first template story. (1) Remove the dangling document-default-currency lookup and reword document-locale to the render-time active locale; formatting is presentation, no new frontmatter fields. (2) Note that identification_number is the reserved field name for any party type (optional for natural persons). (3) Add spec 3.10 permitting placeholder directives as quoted frontmatter values for templates/drafts, reusing the existing placeholder mechanism; add validation row and LLM-reference notes. New CHANGELOG chapter added.