Repository navigation
Security Release - #101
Merged
Merged
Security Release#101
Conversation
The public callback (?wc-api=flw_wc_payment_gateway) gated on !isset($_GET['_wpnonce']) && !wp_verify_nonce(...), so any _wpnonce value skipped verification and an unauthenticated GET could cancel any order by sequential id. - Authenticate the callback against the order key and require the order to use the Flutterwave gateway. - Bind tx_ref to references issued for that order; orders with no stored reference only accept WOOC_<order id>_<suffix>. - Confirm cancellations with Flutterwave before changing an order, and ignore callbacks for orders no longer awaiting payment. - Let the webhook reopen a cancelled order when a verified successful charge arrives, instead of rejecting it as already processed. - Compare verif-hash with hash_equals(), reject webhooks when no secret hash is configured, and drop replayed webhooks. - Encrypt the stored card token at rest and keep webhook PII out of logs unless logging is enabled. - Scope checkout nonces to the order; fix callback URLs on plain permalinks; write order meta through the CRUD API for HPOS. - Bump version to 3.3.1 and add the release notes.
- Remove the unreferenced express-checkout scaffolding in client/blocks/payment-request/ and the unused flutterwave-react-v3, gridicons and @automattic/interpolate-components dependencies, which pulled a vulnerable axios into the dependency tree without reaching the build. - Upgrade the JavaScript dev toolchain (@wordpress/scripts, webpack, Playwright and friends) and require Node 24 via .nvmrc and engines. - Upgrade the PHP dev toolchain to WPCS 3, PHPCompatibilityWP 2.1 and phpunit-polyfills 2, run tests with PHPUnit, and rename the short ternary sniff exclusion for WPCS 3. - Bump GitHub Actions (checkout, cache, setup-node, codecov, composer-install) to current majors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
?wc-api=flw_wc_payment_gateway) against the order key. The endpoint previously accepted any order ID, so an unauthenticated request could cancel or fail arbitrary pending orders (CWE-288 / CWE-306).status=cancelledno longer moves an order on its own.verif-hashwithhash_equals(), and reject webhooks when no secret hash is configured.WOOC_<order id>_…), rather than any reference.client/blocks/payment-request/) and the unusedflutterwave-react-v3,gridiconsand@automattic/interpolate-componentsdependencies, which pulled a vulnerable axios into the dependency tree without reaching the build.