Skip to content

perf(fst): borrow the grammar in apply instead of cloning it #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alex-Wengg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(fst): borrow the grammar in apply instead of cloning it #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/fst/engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,10 @@ fn shortest_output(fst: &VectorFst<TropicalWeight>) -> Option<String> {
/// shortest path's output. Returns `None` if the input is not in the domain
/// (empty composition) or the shortest path emits nothing.
pub fn apply(fst: &VectorFst<TropicalWeight>, input: &str) -> Option<String> {
// Borrow the grammar: cloning it per call copied the whole FST (several MB
// for es verbalize) once per token.
let mut composed: VectorFst<TropicalWeight> =
compose(byte_acceptor(input), fst.clone()).ok()?;
compose::<_, VectorFst<_>, VectorFst<_>, _, _, _>(byte_acceptor(input), fst).ok()?;
if composed.num_states() == 0 || composed.start().is_none() {
return None;
}
Expand Down
Loading