Repository navigation
Conversation
The rollback endpoint accepts an optional mergeEnvVars flag, defaulting to false. The rollback dialog has a checkbox to keep the instance's env vars, ticked by default, and the rolled-back audit entry records the option used.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9009 +/- ##
=======================================
Coverage 79.54% 79.54%
=======================================
Files 475 475
Lines 26076 26076
Branches 6950 6950
=======================================
Hits 20741 20741
Misses 5335 5335
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
added 2 commits
October 23, 2026 12:13
The checkbox was ambiguous about what happens to the snapshot's variables. A radio group now spells out what Merge and Replace each do, and the radio button gains a multiline description variant.
…to 9007-rollback-merge-env-vars
Contributor
|
@knolleary - I am happy to do review and testing on this if it has your blessing. |
knolleary
reviewed
Oct 23, 2026
Member
|
@Steve-Mcl I've added one suggested change to the dialog text based purely on something that caught my eye. I haven't done a deep dive on the implementation - happy for you to handle that. |
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9007
Description
mergeEnvVarsboolean and passes it toimportProjectSnapshot. It defaults to false, so API callers that omit it behave as before.Testing
projectSnapshots_spec.jscoversmergeEnvVarstrue and false, with a key only on the instance and a key only in the snapshot, and checks the audit entry.infofield.mergeEnvVars: true. I haven't run it.