Skip to content

chore: Remove redundant id checks from MCP delete tools - #8875

Merged
andypalmi merged 1 commit into
mainfrom
chore/mcp-remove-redundant-id-checks
Oct 9, 2026
Merged

andypalmi merged 1 commit into
mainfrom
chore/mcp-remove-redundant-id-checks

Conversation

@andypalmi

Copy link
Copy Markdown
Contributor

Description

Follow-up to #8843.

  1. Removes the isHashid checks from the team, pipeline and broker delete tools, along with their handler-level tests.
  2. The same inputs are already refused before the handler runs: the ids are pathId in the input schema, invokeTool rejects any *Id argument that is not a plain segment, and the guarded inject refuses . and .. segments, which covers the broker client username.
  3. No behaviour change. The guard's own tests cover these cases.

Checklist

…ools

The id checks in these handlers repeat what the pathId schemas and the guard in invokeTool already refuse, so they are removed along with their handler-level tests.
@andypalmi
andypalmi requested a review from cstns October 9, 2026 12:04
@andypalmi
andypalmi enabled auto-merge (squash) October 9, 2026 12:16
@codecov

codecov Bot commented Oct 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.53%. Comparing base (ec9a0e4) to head (ce8f051).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8875      +/-   ##
==========================================
- Coverage   78.54%   78.53%   -0.02%     
==========================================
  Files         475      475              
  Lines       25760    25745      -15     
  Branches     6857     6851       -6     
==========================================
- Hits        20234    20219      -15     
  Misses       5526     5526              
Flag Coverage Δ
backend 78.53% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andypalmi
andypalmi merged commit 14ee39f into main Oct 9, 2026
36 of 38 checks passed
@andypalmi
andypalmi deleted the chore/mcp-remove-redundant-id-checks branch October 9, 2026 12:37

This branch was successfully deployed

1 active deployment
staging — ce8f0512 Deployed Oct 9, 2026 by andypalmi via Remove application #12343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants