Repository navigation
feat: Search for existing NodeJS runtime in the Windows Registry - #781
Open
ppawlowski wants to merge 1 commit into
Open
ppawlowski wants to merge 1 commit into
ppawlowski wants to merge 1 commit into
Conversation
ppawlowski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request extends the existing Node.js runtime detection approach for Windows OS by adding the possibility to search for MSI install paths in the Windows Registry. It leaves the existing ProgramFiles environment variables approach as a last-resort fallback.
The Windows-specific candidate lookup now lives in a new build-tagged
system_windows.go(registry first,%ProgramFiles%fallbacks second), with the unchanged Unix paths moved tosystem_unix.go.system.goretains the sharedDetectSystemNodevalidation, so the registry dependency is only compiled into Windows builds.Related Issue(s)
Closes #755
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel