Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
WS-CLI-001-52 — Initial ZIP preparation in the contributor TUI
Goal and intent
Continue merged #695 with one usable contributor action: prepare an initial ZIP and inspect intake feedback. A ready admission is not an immutable Submission; this PR never creates one.
Intent, allowed owners, exclusions, design, acceptance criteria and risk routing: WS-CLI-001-52.
What changed
Scope control
Only the existing TUI, preparation client/caller, focused tests and current docs changed. No backend route, schema, dependency or workflow changes. This cohesive L1 change exceeds the preferred size because it includes model/file-input tests, native terminal wire tests and signed PostgreSQL proof; the change record explains the exception.
Evidence — candidate 918549f
This PR remains draft: hosted full CI found a failing existing guide-compilation concurrency assertion in project_lifecycle_c. Diagnosis is in progress; no merge-readiness claim.
The signed drill uses real Flow verification/JWKS fixture, public routes, PostgreSQL and local ART owners; guest rules use an explicitly named in-process fixture. It is not native checker sandbox, S3 or hosted deployment proof.
Test delta
Added file/packet/identity/state guards, platform input safety and native/public-API preparation cases. Existing read-only, Claim/Start, explicit submission and download proofs remain. No skipped tests, weakened gates or removed assertions.
Impact-routed reviewers
Plan review passed before implementation. Initial exact-head review at
3b6509631found the following issues. All are repaired and replayed at918549f1c:Current clean-head architecture/reuse, security, QA/test delta, product/operations and documentation reviews all pass (security/QA after fixes). Their proof boundaries distinguish executed service/native behavior and stored-row PostgreSQL assertions from source/document consistency; none claims S3, sandbox execution or deployment. Independent stream-guard mutation fails the precise changed-stream/incomplete-body assertions while the complete-body control passes. CI-integrity review found no weakening and verified fail-closed selection/receipt probes; its hosted full-run custody remains pending. Reviews are advisory session evidence, not human approval. Earlier #695 or3b65 reviews are not relabelled to this head.
External review and CI integrity
External review: CodeRabbit skipped review, so it is not fresh review. Current CLI HTTP/API checks and four-platform native proof passed. Full Backend run40489788445 failed project_lifecycle_c:
test_concurrent_live_deliveries_converge_on_one_finalizationexpected the duplicate's intermediateprovider_result_accepted_not_persistedstatus but receivedpolicy_draft_ready. Its 479 tests all executed, 478 passed, no skips, cleanup verified. QA is diagnosing the concrete concurrency assumption; no unchanged-code exemption, assertion weakening, or blind retry is being treated as a pass.Risks and human focus
Caller-owned keys and exact packet/file inputs must be saved outside the session; automatic crash recovery is not implemented. Inspect that a contributor understands the file/packet, blocking versus nonblocking feedback, unknown outcome and the distinction between preparation and Submission. No merge is authorized by this PR.