Feat: save db space by storing horizon as ints#2305
Open
nhoening wants to merge 6 commits into
Open
Conversation
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…onds-level horizons, as queue was not cleared Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Documentation build overview
30 files changed ·
|
Member
|
Good to note: this PR also effectively changes the minimum/maximum belief horizon from what to what? |
Member
Author
To 68 years. I'm not sure what was possible with 2 or 3 bytes more (I forgot right now how many we save), but it doesn't seem so important. Probably a millenia or even more than that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
belief_horizonDB column uses PostgreSQLInterval(16 bytes). Storing seconds asInteger(4 bytes) saves ~12 bytes per row — up to roughly a fifth of total data size.SeitaBV/timely-beliefs#231 makes the change in the db model, this PR does the FlexMeasures side
documentation/changelog.rst