Repository navigation
feat: Support environment-level flag dependency - #19
Merged
Merged
Conversation
emyller
requested review from
khvn26 and
kyle-ssg
and removed request for
a team
October 29, 2026 18:35
khvn26
requested changes
Oct 29, 2026
khvn26
left a comment
khvn26
left a comment
Member
There was a problem hiding this comment.
Looks great! Just one question.
khvn26
approved these changes
Oct 29, 2026
Member
There was a problem hiding this comment.
LGTM.
I think it's safe to tag a release with this, because Renovate won't update the current bump PRs automatically (since they have been pushed to by flagsmithsmith).
Regardless, it should be possible to iterate on spec implementation by pointing the submodule at main/this PR's branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes changes to the harness, and specific test cases.